D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R304:4c6b3afcd80a: KNewStuff: Fix file path and process call (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=81467=81753 REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
alex added a comment. Ups, that makes sense ^^ Thanks! REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir, anthonyfieroni Cc: anthonyfieroni,

D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Anthony Fieroni
anthonyfieroni accepted this revision. anthonyfieroni added a comment. KNewstuff is framework, it has only master. REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven,

D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
alex added a comment. Friendly ping regarding the question :-) REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir Cc: anthonyfieroni,

D29101: KNewStuff: Fix file path and process call

2020-04-28 Thread Alexander Lohnau
alex updated this revision to Diff 81467. alex added a comment. Get program in exclusive line And should this go to release/20.04? REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=81062=81467 BRANCH arcpatch-D29101 REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

2020-04-28 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > installation.cpp:610 > +QStringList args = KShell::splitArgs(command); > +int exitcode = QProcess::execute(args.takeFirst(), args); > Get program in exclusive line auto program = args.takeFirst(); int

D29101: KNewStuff: Fix file path and process call

2020-04-28 Thread Dan Leinir Turthra Jensen
leinir accepted this revision as: leinir. leinir added a comment. This revision is now accepted and ready to land. That's well spotted. Thanks for taking that one on :) REPOSITORY R304 KNewStuff BRANCH bugfix_uninstall (branched from master) REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

2020-04-27 Thread Nathaniel Graham
ngraham added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29101: KNewStuff: Fix file path and process call

2020-04-24 Thread Alexander Lohnau
alex added a dependent revision: D29123: Do not mark entry as uninstalled if uninstallation script failed. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: kde-frameworks-devel,

D29101: KNewStuff: Fix file path and process call

2020-04-24 Thread Alexander Lohnau
alex retitled this revision from "WIP Fix file path and process call" to "KNewStuff: Fix file path and process call". REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: