D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

2020-04-30 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b0d4c4bdaed: [PlasmaCore.IconItem] Regression: fix crash on source change (authored by kmaterka). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

2020-04-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. This also fixes another crash I was seeing with the ExpandableListItem applets. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

2020-04-30 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

2020-04-30 Thread Konrad Materka
kmaterka edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

2020-04-30 Thread Konrad Materka
kmaterka edited the summary of this revision. kmaterka edited the test plan for this revision. kmaterka added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson

D29314: [PlasmaCore.IconItem] Regression: fix crash on source change

2020-04-30 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY When SvgSource is changed, old one is deleted. Connections are