D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi abandoned this revision. weisi added a comment. Closing this revision. Let's get D29223 in. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: nhiga, kde-frameworks-devel,

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi added a comment. I agree with the general idea in D29223 and feel D29223 is in a better shape than this diff. However, I think some festivals referred to in this diff (not mentioned in the law - 紀念日及節日實施辦法

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

nhiga added a comment. > specified the start year of Peace Memorial Day 228和平紀念日 Great! This is what I have missed in my patch. > The star * ones are specified using the "lunar new year date" minus/plus some days, hoping to make it easier to adapt to additional years in the future.

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

nhiga added a reviewer: cgiboudeaux. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi updated this revision to Diff 81772. weisi added a comment. Renamed "農曆除夕" (//Lunar New Year's eve on Lunar calendar//) to "除夕" (//Lunar New Year's eve//). There's no need to specify "lunar calendar" here. REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi created this revision. weisi added a reviewer: winterz. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY The previous revision put in fixed dates (month/day) for many holidays which are actually