D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz added a comment. I committed this one for Weisi Dai REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R175:682b18f75ca7: holidays/plan2/holiday_gb-sct_en-gb (authored by weisi, committed by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29374?vs=81773=81953

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz accepted this revision. winterz added a comment. do you need me to commit this for you? my fault. I should have run the test that looks for the syntax errors .. I don't recall doing that. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To:

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-03 Thread Jonathan Riddell
jriddell added a comment. thanks :) REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-02 Thread Weisi Dai
weisi created this revision. weisi added a reviewer: winterz. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY It's a trivial fix, but this syntax error poped up when I was doing another holiday