D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

broulik added inline comments. INLINE COMMENTS > knotification.h:253 > */ > CloseWhenWidgetActivated = 0x04, > Should we deprecate this? Or just use this one instead. I don't see why we would have separate enum values for those REPOSITORY R289 KNotifications REVISION

D29391: Introduce setWindow and CloseWhenWindowActivated

anthonyfieroni added inline comments. INLINE COMMENTS > knotification.cpp:263 > d->needUpdate = true; > d->flags = flags; > if (d->id >= 0) { Flags can be changed, disconnect window, if present and activation flags is not set, connect in opposite. > knotification.cpp:585 > + >

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella updated this revision to Diff 83051. nicolasfella added a comment. - Address APIdocs issues - Remove timer REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29391?vs=81822=83051 BRANCH closewin REVISION DETAIL

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? lol, turns out that

D29391: Introduce setWindow and CloseWhenWindowActivated

kossebau added inline comments. INLINE COMMENTS > knotification.h:582 > > +/** Sets the window associated with this notification. > + * This is relevant when using the CloseWhenWindowActivated flag. And some remarks from a local API docs pedant :) Please place the text not on the

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > Generally +1 > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? I'll

D29391: Introduce setWindow and CloseWhenWindowActivated

broulik added a comment. Generally +1 The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? Not a fan of the timer. Also, we might want to deprecate the `QWidget` one now? REPOSITORY R289

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a replacement for CloseOnWidgetActivated that