D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Noah Davis
ndavis added a comment. In D29740#671221 , @filipf wrote: > The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf added a comment. The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for providing the same svg for `focus-background` and `pressed`. REPOSITORY R242 Plasma

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH dont-remain-pressed (branched from master) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma, ngraham Cc:

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf added a dependent revision: D29741: [Logout] Port to QQC2 and PC3. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: davidedmundson, mart, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc:

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We have two interfering button background items right now: - surfaceNormal when it has activeFocus and is using