D29742: Avoid potential disconnect of all signals in IconItem

2020-05-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c215c54eced5: Avoid potential disconnect of all signals in IconItem (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D29742: Avoid potential disconnect of all signals in IconItem

2020-05-14 Thread Arjen Hiemstra
ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. This fixes bug 421170 for me. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29742 To: davidedmundson, #plasma, ahiemstr

D29742: Avoid potential disconnect of all signals in IconItem

2020-05-14 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY m_svgIcon can be null. disconnect(q, nullptr, nullptr, nullp