D29789: Make text always align with font base line

cullmann closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D29789: Make text always align with font base line

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, looks better for me, too. Let's go with this at the moment. If it creates issues, we can still revert it again. Thanks for taking care of this. For the option: some

D29789: Make text always align with font base line

brauch added a comment. Hmm, consider though that a configuration option should be something that gives a choice to the user. It shouldn't be necessary to set a config option in order to make the program behave correctly. REPOSITORY R39 KTextEditor REVISION DETAIL

D29789: Make text always align with font base line

xuetianweng added a comment. In D29789#672335 , @dhaumann wrote: > I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate,

D29789: Make text always align with font base line

dhaumann added a comment. I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate, leading to much more overpainting that needed. If this patch fixes this, then I'm all

D29789: Make text always align with font base line

xuetianweng added a comment. This is my another try as an alternative solution to D25339 . Actually this works surprisingly good IMHO, at least for CJK users for most cases. REPOSITORY R39 KTextEditor REVISION DETAIL

D29789: Make text always align with font base line

xuetianweng edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann,

D29789: Make text always align with font base line

xuetianweng created this revision. xuetianweng added reviewers: rjvbb, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. xuetianweng requested review of this revision. REVISION SUMMARY When font uses other fallback font,