ltoscano added a comment.
I believe a few sentences in the the commit message contradicts each other.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D29802
To: ngraham, #frameworks, #vdg, ognarb, davidre
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n,
davidre requested changes to this revision.
davidre added a comment.
This revision now requires changes to proceed.
I don't think we want to require in source builds
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D29802
To: ngraham, #frameworks, #vdg, ognarb,
ognarb accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
require-in-source-build (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29802
To: ngraham, #frameworks, #vdg, ognarb
Cc: kde-frameworks-devel,
ngraham created this revision.
ngraham added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
In addition to just being a good idea in general, the dynamic icon
