D29809: Don't invoke qstring localized stuff in critical section

dfaure added a comment. Done in https://invent.kde.org/frameworks/kcrash/commit/c315685f0e0920e8847afe12c97fbbe4653eb351 REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29809: Don't invoke qstring localized stuff in critical section

This revision was automatically updated to reflect the committed changes. Closed by commit R285:c315685f0e09: Dont invoke qstring localized stuff in critical section (authored by dfaure). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29809?vs=83231=83233

D29809: Don't invoke qstring localized stuff in critical section

jpalecek added a comment. In D29809#674721 , @dfaure wrote: > The changes you mention don't appear in phabricator. > > I suggest amending your commit locally (so there's only one) and then > > arc diff HEAD~ Just to clarify. I

D29809: Don't invoke qstring localized stuff in critical section

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29809: Don't invoke qstring localized stuff in critical section

jpalecek updated this revision to Diff 83231. jpalecek added a comment. Really commit the last changes REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29809?vs=83213=83231 BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29809 AFFECTED

D29809: Don't invoke qstring localized stuff in critical section

dfaure added a comment. The changes you mention don't appear in phabricator. I suggest amending your commit locally (so there's only one) and then arc diff HEAD~ REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc:

D29809: Don't invoke qstring localized stuff in critical section

jpalecek updated this revision to Diff 83213. jpalecek added a comment. Renamed the socketpath variable to s_socketpath, and make it static as requested REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29809?vs=83136=83213 BRANCH for-upstream REVISION

D29809: Don't invoke qstring localized stuff in critical section

dfaure added a comment. Makes sense; just two minor things. INLINE COMMENTS > kcrash.cpp:95 > +#ifdef Q_OS_LINUX > +QByteArray socketpath; > +#endif prepend `static`, it's only used in this file. > kcrash.cpp:662 > > -// Create socket path to transfer ptrace scope and open

D29809: Don't invoke qstring localized stuff in critical section

jpalecek added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29809: Don't invoke qstring localized stuff in critical section

jpalecek updated this revision to Diff 83136. jpalecek retitled this revision from "Don't invoke QString localized stuff in critical section" to "Don't invoke qstring localized stuff in critical section". jpalecek edited the summary of this revision. jpalecek added a comment. (edited the

D29809: Don't invoke QString localized stuff in critical section

jpalecek retitled this revision from "t/dont-invoke-qstring-localized-stuff-in-critical-section" to "Don't invoke QString localized stuff in critical section". jpalecek edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: