D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

ngraham closed this revision. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson, anthonyfieroni Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

ngraham added a comment. Fair enough. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson, anthonyfieroni Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. @ngraham i don't think it's needed this for existing reviews, it's double work for nothing. It has 2 weeks testing before 5.71 release just push it, it can be reverted if

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

ngraham added a comment. You might have more luck migrating this to https://invent.kde.org. https://community.kde.org/Infrastructure/GitLab REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: ngraham, anthonyfieroni,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a comment. @davidedmundson I hoped this could make it into 5.71 or is it too late now? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

anthonyfieroni added a comment. Wait @davidedmundson to accept it. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a comment. Do I need to change anything or is this acceptable? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a comment. @davidedmundson What do you think about this patch? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

anthonyfieroni added a reviewer: davidedmundson. anthonyfieroni added a comment. So change should be fine, (https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) since KDED loads only modules they don't know where and when qApp is instantiated. REPOSITORY R297 KDED

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

zzag added a comment. In D29815#672682 , @anthonyfieroni wrote: > Is that KWin that set titlebar menus? from `#plasma` irc 5:02:41 PM kded does not load kwin 5:03:15 PM I believe the appmenu version where it's shown in the title

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

zzag removed a reviewer: zzag. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a comment. This patch also fixes buttons in kded dialogs like the wifi password dialog. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, zzag Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

anthonyfieroni added a reviewer: zzag. anthonyfieroni added a comment. Is that KWin that set titlebar menus? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, zzag Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a comment. I don't know enough about kded to answer your question. I just know this fixes the issue and it works fine with other apps, which may or may not be relevant. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc:

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

broulik added a comment. I am not sure we can just do this given the amount of modules kded loads. Can we be certain that all the modules don't do custom pixmap painting? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: broulik,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a reviewer: Frameworks. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mthw requested review of this revision. REVISION SUMMARY When using fractional scaling, icons in titlebar appmenu are blurred in all apps. This patch fixes the issue. TEST PLAN