This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6df656252bf7: Add new component for the greyed out labels
in Item Delegates. (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson updated this revision to Diff 11981.
davidedmundson added a comment.
Add @inherits
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4831?vs=11923=11981
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4831
davidedmundson added a comment.
I'm going to merge after Marco merges the QQC2 stuff that way we can inherit
directly from the newest label without having to worry about versioning this.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Nice. Note Kicker has some of those greyed out labels IIRC.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL PREFERENCES
sebas added a comment.
I like it. If kbroulik is happy, consider that a +1 from me, too.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
broulik added inline comments.
INLINE COMMENTS
> DescriptiveLabel.qml:41
> + * properties, methods and signals.
> + */
> +Label {
@inherits ?
> DescriptiveLabel.qml:48
> + * property should be set to true when the label is being interacted
> with.
> + * The default is false
> + */
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Plasma code is full of Label {opacity: 0.6}. We shouldn't be hardcoding
style into a UI, especially with magic
