D4975: Prevent misdetection of EOF on Linux

2017-04-26 Thread Peter Wu
Lekensteyn added a comment. (FWIW, I ran a patched kpty 5.32.0-1 version for a while and didn't have the hang issue until I recently upgraded to an unpatched 5.33.0-1. Haven't had a moment so far to dig deeper into the issue though.) REPOSITORY R291 KPty REVISION DETAIL https://phabrica

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Oswald Buddenhagen
ossi added a comment. yeah, but without knowing the root cause, your fix may be just wrong, or at least the comment/commit message may be misleading. also, https://community.kde.org/Policies/Commit_Policy#Don.27t_commit_code_you_don.27t_understand REPOSITORY R291 KPty REVISION DETAIL

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Peter Wu
Lekensteyn added a comment. In https://phabricator.kde.org/D4975#95754, @ossi wrote: > first try googling it; maybe there is even a response on stackoverflow (as so often happens). Was one of the first things to try, that only pointed to an issue in Emacs and another that clarifi

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Oswald Buddenhagen
ossi added a comment. first try googling it; maybe there is even a response on stackoverflow (as so often happens). then try posting it yourself to stackoverflow. dunno whether such questions are welcome on the linux-kernel list, but if not, there might be other lists where it would fit.

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Peter Wu
Lekensteyn added a comment. In https://phabricator.kde.org/D4975#95727, @ossi wrote: > please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path). I suspect it is a kernel bug, b

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Oswald Buddenhagen
ossi added a comment. please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path). if this is a bug, does it actually affect released versions which are not being "upgraded away" on short n

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Christoph Feck
cfeck added a reviewer: ossi. REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg, ossi Cc: #frameworks

D4975: Prevent misdetection of EOF on Linux

2017-03-08 Thread Kurt Hindenburg
hindenburg added a comment. Thanks, this needs to get reviewed by the framework team that handles KPty. REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg Cc: #frameworks

D4975: Prevent misdetection of EOF on Linux

2017-03-08 Thread Peter Wu
Lekensteyn created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On Linux, even if slave activity is detected on a master fd, FIONREAD can still return zero available bytes in the buffer. Previously th