D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f65946ece03c: Handle/truncate url display string assigned to job description. Prevents large… (authored by Lim Yuen Hoe ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Ship it ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013 To: yuenlim, #plasma, dfaure Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

yuenlim updated this revision to Diff 12411. yuenlim added a comment. Got it! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5013?vs=12403=12411 REVISION DETAIL https://phabricator.kde.org/D5013 AFFECTED FILES src/core/job.cpp To: yuenlim, #plasma,

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Yes; looks much nicer, doesn't it? INLINE COMMENTS > job_p.h:76 > Job *q_ptr; > +static const int DescriptionUrlMaxLength = 100; > This can now be moved to the helper function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Extra credit for factorizing this into a file-static function and handling data: URLs separately (no point in seeing 100 chars of data crap, we could do data:[...] or something like that).

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

yuenlim updated this revision to Diff 12391. yuenlim added a comment. Use KStringHandler::csqueeze for truncating! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5013?vs=12380=12391 REVISION DETAIL https://phabricator.kde.org/D5013 AFFECTED FILES

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Can you use KStringHandler::csqueeze ? This way filenames are still visible. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013 To: yuenlim, #plasma Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

yuenlim created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When posting large raw image data to imgur in QuickShare, the KIO job ends up triggering a notification that displays