habacker added a comment.
Looking into the bug report gaves the answer:
file /usr/i686-w64-mingw32/sys-root/mingw/bin/ksendbugmail.exe from install
of mingw32-libKF5XmlGui5-5.26.0-3.1.noarch conflicts with file from package
mingw32-kdelibs4-4.14.60-11.4.noarch
For the recored:
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
Ben's question was never answered...
REPOSITORY
R263 KXmlGui
REVISION DETAIL
bcooksley added a comment.
From my understanding of this on Linux/FreeBSD the install destinations for
these binaries are different. On Windows you should have one install prefix per
application and you can't mix Qt versions in an application.
So i'm not seeing how we end up with a
habacker added reviewers: ltoscano, bcooksley.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5173
To: habacker, dfaure, ltoscano, bcooksley
Cc: bcooksley, dfaure, aacid, #frameworks
habacker added a reviewer: dfaure.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5173
To: habacker, dfaure
Cc: bcooksley, dfaure, aacid, #frameworks
bcooksley added a comment.
In https://phabricator.kde.org/D5173#124620, @habacker wrote:
> BTW: You mentioned that KF5_LIBEXEC_INSTALL_DIR is 'bin/libexec/kf5/' on
Windows, Should it not be lib/libexec/kf5 ? On unix this is located in
'lib[64]/libexec/kf5 ' - why this difference ?
habacker added a comment.
> So bin isn't in %PATH%, but found relatively to the app being run?
yes
> This makes me wonder if libexec could be bin/libexec/kf5/ on Windows,
relative too.
This requires to add support for finding executables located in libexec based
on install
dfaure added a comment.
So bin isn't in %PATH%, but found relatively to the app being run?
This makes me wonder if libexec could be bin/libexec/kf5/ on Windows,
relative too.
Then we could have an ECM-provided string that expands to
CMAKE_INSTALL_PREFIX "/" KF5_LIBEXEC_INSTALL_DIR
habacker added a comment.
In any discussion about libexec related issues we keep hitting the fact that
there is no standard env var for it. Maybe we need a custom one (which could
then be KF5_LIBEXEC_PATH, so it won't conflict with KF6).
Because every KDE application installers bundles a
habacker added a comment.
> The question is, can you add libexec to the path (so that findExecutable
works) only for kf5-based executables (so that kde4 apps don't break) ?
no
> If not, then your description of the problem was incorrect and this is not
just about dbus-started
dfaure added inline comments.
INLINE COMMENTS
> habacker wrote in kbugreport.cpp:527
> BTW: This will not work on Windows because the absolute build time install
> path is used which differs in mostly cases from the runtime install path.
Which is why this is just a fallback ;)
The question
dfaure added a comment.
Well I would accept a compromise, where dbus-started services get installed
in bin on Unix as well.
Which means still only two install vars and dirs: bin and libexec. With
consistency between Unix and Windows about whether a given executable gets
installed into bin
habacker added inline comments.
INLINE COMMENTS
> kbugreport.cpp:527
> if (command.isEmpty()) {
> -command = QFile::decodeName(CMAKE_INSTALL_PREFIX "/"
> KF5_LIBEXEC_INSTALL_DIR "/ksendbugmail");
> +command = QFile::decodeName(CMAKE_INSTALL_PREFIX "/"
>
habacker added a comment.
I did not took a look into every location where an executable is installed
into KDE_INSTALL_LIBEXECDIR_KF5, but I guess on Windows any application which
may be started *only* by a KF5 provided api may be located in the libexec dir ;
all other needs to stay into
dfaure added a comment.
If "findable by dbus services" is the only argument for polluting bin with
libexec binaries on Windows, then it doesn't apply to *everything* in libexec,
only to a handful of executables.
lib64/libexec/kauth/backlighthelper
lib64/libexec/kauth/discretegpuhelper
habacker added a comment.
You saw the related bug report at https://bugs.kde.org/show_bug.cgi?id=374347
?
"ksendbugmail is installed into KDE_INSTALL_LIBEXECDIR_KF5, which seems to be
set on Windows to 'bin'. At KDE4 times all executables are installed in
/bin to be findable by dbus
aacid added a comment.
Are you sure this is needed, they get installed in different prefixes so
what's the problem?
/usr/lib/kde4/libexec/ksendbugmail
/usr/lib/x86_64-linux-gnu/libexec/kf5/ksendbugmail
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5173
To:
habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The executable is now named ksendbugmail5.
BUG:374347
REPOSITORY
R263 KXmlGui
BRANCH
374347
REVISION DETAIL
18 matches
Mail list logo
