D5431: New LESS syntax based on SCSS

2017-08-21 Thread Yunhe Guo
guoyunhe abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate, cullmann Cc: jtamate, gszymaszek, dhaumann, cullmann, #frameworks

D5431: New LESS syntax based on SCSS

2017-08-21 Thread Christoph Cullmann
cullmann added a comment. Ok, thanks for comparing it. Sorry that I didn't look at it earlier, my fault :/ You can abandon this change then. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #framework_syntax_hightlighting,

D5431: New LESS syntax based on SCSS

2017-08-21 Thread Yunhe Guo
guoyunhe added a comment. They didn't include any screenshots in https://phabricator.kde.org/D5799 so I make my own: F3871416: Screenshot_20170821_113740.png The results are almost the same except text styles. Left is theirs, right is mine.

D5431: New LESS syntax based on SCSS

2017-08-21 Thread Dominik Haumann
dhaumann added subscribers: gszymaszek, jtamate. dhaumann added a comment. In that case, can you judge whether your patch or the other one is better? Add for review: @gszymaszek @jtamate REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To:

D5431: New LESS syntax based on SCSS

2017-08-21 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D5431#138044, @dhaumann wrote: > Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...

D5431: New LESS syntax based on SCSS

2017-08-21 Thread Dominik Haumann
dhaumann added a comment. Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier... REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D5431: New LESS syntax based on SCSS

2017-08-21 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, given I have no real idea about this HL, looks not wrong, but could you add/extend a unit test? Then this can go in I would say. Thanks for the change! REPOSITORY

D5431: New LESS syntax based on SCSS

2017-04-15 Thread Yunhe Guo
guoyunhe added reviewers: KTextEditor, Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5431: New LESS syntax based on SCSS

2017-04-13 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It is a modified version of SCSS syntax. Major difference is variable start with @ instead of $. It performs better with LESS' nested