winterz closed this revision.
winterz added a comment.
committed in
https://phabricator.kde.org/R238:5c5bfc2d838993f7d4be1885dff822e3794c529f
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc: kfunk, #frameworks, #documentation,
ltoscano accepted this revision.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc: kfunk, #frameworks, #documentation, skadinna
winterz updated this revision to Diff 13520.
winterz added a comment.
I added comments.
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5456?vs=13448=13520
REVISION DETAIL
https://phabricator.kde.org/D5456
AFFECTED FILES
cmake/FindDocBookXML4.cmake
kfunk added a comment.
It's a "fix it, then ship it" like acceptance.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc: kfunk, #frameworks, #documentation, skadinna
ltoscano added a comment.
if a comment should be added, then the review should not be accepted (yet)
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc: kfunk, #frameworks, #documentation, skadinna
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
I'd say: Add a comment that this is for OS X/homebrew then it's okay as-is.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc:
ltoscano added a comment.
opt/docbook-xsl/ ? O.o
Well, not up to me to discuss that.
Just a question, no need for ${CMAKE_INSTALL_DATAROOTDIR}? I understand that
it's a suffix, so not required, but if it was /opt, maybe it could be changed
to ${CMAKE_INSTALL_DATAROOTDIR}/docbook etc etc
winterz created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
On Mac, homebrew installs the docbook-xml and docbook-xls files under
/usr/local/opt
so add searchpaths
