D5463: Pug/Jade Syntax

2017-08-23 Thread Yunhe Guo
guoyunhe abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

D5463: Pug/Jade Syntax

2017-06-03 Thread Yunhe Guo
guoyunhe added a comment. Could someone approve this patch? So I can commit it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

D5463: Pug/Jade Syntax

2017-04-24 Thread Yunhe Guo
guoyunhe updated this revision to Diff 13734. guoyunhe added a comment. Remove mimetype REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5463?vs=13459=13734 REVISION DETAIL https://phabricator.kde.org/D5463 AFFECTED FILES

D5463: Pug/Jade Syntax

2017-04-24 Thread Volker Krause
vkrause added a comment. yep, keep the mimetype field empty in that case REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

D5463: Pug/Jade Syntax

2017-04-24 Thread Yunhe Guo
guoyunhe added a comment. I found this part might be a bug in this syntax highlight: mimetype="text/plain" It will highlight all plain text file to pug syntax. Should I just change mimetype to empty? Not sure how to write it for files that don't have registered mimetype.

D5463: Pug/Jade Syntax

2017-04-16 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D5463#102409, @dhaumann wrote: > Do you also agree to release this highlighting file under MIT license? Same for the test case you attached? Also, can we use this test case for unit testing? It is okay. I can release the

D5463: Pug/Jade Syntax

2017-04-15 Thread Dominik Haumann
dhaumann added a comment. Do you also agree to release this highlighting file under MIT license? Same for the test case you attached? Also, can we use this test case for unit testing? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe,

D5463: Pug/Jade Syntax

2017-04-15 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5463: Pug/Jade Syntax

2017-04-15 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5463: Pug/Jade Syntax

2017-04-15 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN F3709335: Screenshot_20170415_14.png F3709391: standard.pug