This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for
e.g. MSVC (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
bcooksley accepted this revision.
bcooksley added a comment.
Looks good to me - thanks for taking this on, it'll make getting CI working
for Windows much easier.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5489
To: kfunk, aacid,
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Makes sense, the other option would be actually erroring out as we do in
check_compiler_version if you don't run "the correct clang/gcc", but i guess
this may be enough for MSVC at this
kfunk added reviewers: aacid, bcooksley.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5489
To: kfunk, aacid, bcooksley
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Fixes compiler warnings such as:
cl : Command line warning D9002 : ignoring unknown option
