This revision was automatically updated to reflect the committed changes.
Closed by commit R296:3743d6400da9: Don't accept hover events in the DragArea
(authored by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5573?vs=13766=13881
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
The FV side does rely on onDragMove firing, which is understand it still does
regardless, so +1.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
aacid added a comment.
What about in the FolderView side?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D5573
To: davidedmundson, #plasma
Cc: aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
davidedmundson added a comment.
In https://phabricator.kde.org/D5573#104619, @aacid wrote:
> "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this
worth adding an auto test somewhere?
Maybe, but it'd be testing that an item doesn't do what it had no reason
aacid added a comment.
"Setting it enabled broke FolderView nested in a grouping Plasmoid" is this
worth adding an auto test somewhere?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D5573
To: davidedmundson, #plasma
Cc: aacid, plasma-devel, #frameworks,
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We don't actually process hoverEnter/move events, so there's no need to
have the overhead of having them sent
