jriddell abandoned this revision.
jriddell added a comment.
submitted
REVISION DETAIL
https://phabricator.kde.org/D5615
To: jriddell, #frameworks, mart
Cc: apol
jriddell added a comment.
works if I add a .cmake to the end of the include() value
REVISION DETAIL
https://phabricator.kde.org/D5615
To: jriddell, #frameworks, mart
Cc: apol
jriddell updated this revision to Diff 13865.
jriddell added a comment.
without changing include path
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5615?vs=13863=13865
REVISION DETAIL
https://phabricator.kde.org/D5615
AFFECTED FILES
KF5PackageMacros.cmake
To: jriddell,
apol added inline comments.
INLINE COMMENTS
> KF5PackageMacros.cmake:4
> +set(CMAKE_MODULE_PATH ${ECM_KDE_MODULE_DIR})
> include(KDEInstallDirs)
>
How about `include(${ECM_KDE_MODULE_DIR}/KDEInstallDirs)`?
This way we don't mess with CMAKE_MODULE_PATH.
REPOSITORY
R290 KPackage
REVISION
jriddell created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KF5PackageMacros.cmake uses ECM without setting the include path so it can't
be found. This isn't usually seen as usually something else will set the path
before this.
