This revision was automatically updated to reflect the committed changes.
Closed by commit R263:4690808e65f1: use transientparent directly (authored by
mart).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5900?vs=14630&id=14631
REVISION DETAIL
https://phab
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Tested, works (neither kontact nor okular crash with this change).
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5900
To: mart, lbeltrame
lbeltrame added a reviewer: lbeltrame.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5900
To: mart, lbeltrame
Cc: lbeltrame, #frameworks
lbeltrame added a comment.
I'll test this and see how it goes.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5900
To: mart
Cc: lbeltrame, #frameworks
mart updated this revision to Diff 14630.
mart added a comment.
call windid only once
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5900?vs=14629&id=14630
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5900
AFFECTED FILES
src/kxmlguifa
mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
don't parent directly as we don't want unwanted deletions.
ensure we have a menu, not parented yet, the container exists,
both the menu and
