This revision was automatically updated to reflect the committed changes.
Closed by commit R304:0b44a25b5df4: Give a parent to KMoreToolsMenuFactory
menus (authored by elvisangelaccio).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6008?vs=15197=16464#toc
REPOSITORY
R304 KNewStuff
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6008
To: elvisangelaccio, mart, #frameworks, dfaure
Cc: #frameworks
elvisangelaccio added a reviewer: Frameworks.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6008
To: elvisangelaccio, mart, #frameworks
Cc: #frameworks
elvisangelaccio added a comment.
Ping?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6008
To: elvisangelaccio, mart
Cc: #frameworks
elvisangelaccio updated this revision to Diff 15197.
elvisangelaccio added a comment.
- Bumped @since
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6008?vs=14932=15197
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6008
AFFECTED FILES
elvisangelaccio added a comment.
Note: we could also deprecate the current createMenuFromGroupingNames() in
favor of a new createMenuFromGroupingNames() that takes an addition QWidget*
argument. Not sure which way is the best.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
A QMenu without a parent will be wrongly positioned on Wayland.
TEST PLAN
KMoreToolsMenuFactory menu in Dolphin status bar now
