This revision was automatically updated to reflect the committed changes.
Closed by commit R242:563011436d5f: Port a bunch of classes away from
Plasma::Package (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
apol added a comment.
Yes sure.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6041
To: apol, #frameworks, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed,
davidedmundson added a comment.
Can we wait till after the next release is tagged as that's super soon and
this isn't that important.
We've had major bugs porting stuff in this area before.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6041
To: apol, #frameworks, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
apol updated this revision to Diff 15015.
apol marked an inline comment as done.
apol added a comment.
Address Marco's comments
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6041?vs=15003=15015
BRANCH
master
REVISION DETAIL
apol marked 2 inline comments as done.
apol added inline comments.
INLINE COMMENTS
> mart wrote in appletquickitem.h:105
> despite the warning in the header, this ended up being an exported symbol, so
> binary compatibility rules apply here too.
> Plasma::Package appletPackage() const; has to
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pluginloader.h:208
> + **/
> +PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const
> QString );
> +
wow, phab isn't that smart in the
apol created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ported away some classes, removes many unneeded casts that happen when
starting.
TEST PLAN
Tests still pass, plasma starts
