This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to
textChanged() for text property. (authored by arrowdodger).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6102
To: arrowdodger, #frameworks, dfaure
Cc: apol, elvisangelaccio, kfunk
apol added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kurlrequester.h:71
> Don't we need to add apidox with the @since tag?
Well not really, maybe if we documented the properties instead of the methods
(which could be a sensible thing to do on the other hand).
REPOSITORY
elvisangelaccio added inline comments.
INLINE COMMENTS
> kurlrequester.h:71
> Q_PROPERTY(QString placeholderText READ placeholderText WRITE
> setPlaceholderText)
> -Q_PROPERTY(QString text READ text WRITE setText)
> +Q_PROPERTY(QString text READ text WRITE setText NOTIFY
kfunk added a comment.
+1 from my side -- Please wait for another +1 from another person.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6102
To: arrowdodger, #frameworks
Cc: kfunk
arrowdodger created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Having `NOTIFY textChanged` on `text` property may come useful when using
KUrlRequester with KConfig. KUrlRequester field may hold paths for executables
and sometimes it is more convenient
