This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e48e34bd0288: Add since tags. (authored by tfry).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6122?vs=15226=15376
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Excellent idea. I would say, we should have done the same in other new
frameworks. If we treat KF5 as a whole, then these classes are simply "new
since 5.28" in a bigger "package" that
tfry added a comment.
In https://phabricator.kde.org/D6122#114655, @cfeck wrote:
> Since this frameworks is new as of 5.28, should we really mark each class
this way? We did not do this for other "new" frameworks, such as prison or
kwayland.
You mean, if I'm not sure whether the
cfeck added a comment.
The patch is simple, but it is always a good idea to ask for a review.
Since this frameworks is new as of 5.28, should we really mark each class
this way? We did not do this for other "new" frameworks, such as prison or
kwayland.
REPOSITORY
R216 Syntax
tfry created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I hate having to look up when interesting new classes were added.
Patch is straight-forward (I think), but:
- should @since be added on all memebers, when it's already on the class?
- would
