This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.
Closed by commit R249:77eab970fde3: Make sure that the tsfiles target is
generated (authored by apol).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
ltoscano accepted this revision.
ltoscano added a comment.
The issue initially reported is fixed. I tried with //fr// and other 3
languages which should be representative enough (//de//, //uk//,
//sr@ijekavian//; the latter was complaining before the last revision of the
review).
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> ltoscano wrote in KF5I18NMacros.cmake:178
> Before this line, in the original version before the changes, there was this
> line:
>
> string(REPLACE "@" "_" pmapc_target ${pmapc_target})
>
> Could it be
apol updated this revision to Diff 16202.
apol added a comment.
- Restore the old behavior of KI18N_INSTALL_TS_FILES
- Address luigi's comment
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6331?vs=16136=16202
BRANCH
master
REVISION DETAIL
ltoscano added a comment.
It seems to work, just one question though:
INLINE COMMENTS
> KF5I18NMacros.cmake:178
> + set(pmapc_target "pmapfiles-${lang}")
> + add_custom_target(${pmapc_target} ALL DEPENDS ${pmapc_files})
> + add_dependencies(pmapfiles ${pmapc_target})
Before
apol updated this revision to Diff 16136.
apol added a comment.
- Restore the old behavior of KI18N_INSTALL_TS_FILES
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6331?vs=15720=16136
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6331
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
In https://phabricator.kde.org/D6331#118513, @lueck wrote:
> locale fr or uk build now, but without the script files beeing installed.
> Looks like ./scripts/autogen.sh needs
lueck added a comment.
locale fr or uk build now, but without the script files beeing installed.
Looks like ./scripts/autogen.sh needs to be adapted as well
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D6331
To: apol, #frameworks, ltoscano, lueck
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I'm not sure how it's possible that pofiles is defined but tsfiles
isn't, but this does fix the issue reported by Luigi:
CMake Error at /usr/lib64/cmake/KF5I18n/KF5I18NMacros.cmake:129
