wbauer added a comment.
In https://phabricator.kde.org/D6701#130417, @apol wrote:
> Maybe a next iteration after merging this moving the function out of the
`if` would be useful.
Probably a good idea, yes.
I'll have a look at it in the next days...
REPOSITORY
R240 Extra CMake
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:899519f0be03: Make ECMPoQmToolsTest actually fail if a
translation is wrong (authored by wbauer).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6701?vs
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Right, thanks. Your explanation + coffee helped.
Maybe a next iteration after merging this moving the function out of the `if`
would be useful.
REPOSITORY
R240 Extra CMake Modules
REVIS
wbauer added inline comments.
INLINE COMMENTS
> apol wrote in check.cmake.in:79
> It should also change the other `set(fail)` calls.
>
> Or am I missing something?
The other `set(fail)` calls *are* at the top-level and not inside a function.
So, no, it doesn't make sense there.
The function on
apol added inline comments.
INLINE COMMENTS
> check.cmake.in:79
> message(WARNING "${name}[${lang}] output was
> \"${stripped_output}\", but expected
> \"${exp_output_${catalog_name}_${lang}}\"")
> -set(fail ON)
> +set(fail ON PARENT_SCOPE)
>
aacid added a subscriber: apol.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6701
To: wbauer, skelly
Cc: apol, #frameworks, #build_system
wbauer updated this revision to Diff 16705.
wbauer added a comment.
New diff with full context.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6701?vs=16701&id=16705
REVISION DETAIL
https://phabricator.kde.org/D6701
AFFECTED FILES
tests/EC
wbauer added a comment.
From the cmake documentation:
> set( ... [PARENT_SCOPE])
>
> Set the given in the current function or directory scope.
>
> If the ``PARENT_SCOPE`` option is given the variable will be set in
> the scope above the current scope. Each new directory
wbauer created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Currently the test still passes even if one of the check_translations() calls
fail.
The reason is that check_tran
