D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

This revision was automatically updated to reflect the committed changes. Closed by commit R240:03fc1de44ef9: Fix usage of query_qmake: differ between calls expecting qmake or not (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. In https://phabricator.kde.org/D6772#129531, @apol wrote: > Works for me. > Are you sure we don't need to include the `TRY` on other calls? Any calls you would be thinking off? The ones where this patch does not add `TRY` are in code which expects

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Works for me. Are you sure we don't need to include the `TRY` on other calls? REPOSITORY R240 Extra CMake Modules BRANCH handlenoqmakefound REVISION DETAIL

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau marked an inline comment as done. kossebau added a comment. If there are no objections, will push on Saturday, 29th July REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau updated this revision to Diff 16912. kossebau added a comment. - use cmake_parse_arguments - fix english grammar in dox REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6772?vs=16880=16912 BRANCH handlenoqmakefound REVISION DETAIL

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. A regression due to https://phabricator.kde.org/R240:8ac7abb78d97210c5cbbc87fba83d58d7b843a8d Seems the "it allows for modules using it to decide what they should do" was never told the modules using it ;) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. In https://phabricator.kde.org/D6772#126799, @apol wrote: > What's the background for the change? When KDE_INSTALL_USE_QT_SYS_PATHS is explicitely set to ON but no qmake-qt5 executable found (like @rdieter reported to be possible on fedora packaging),

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

apol added a comment. What's the background for the change? INLINE COMMENTS > ECMQueryQmake.cmake:19 > if(NOT QMAKE_EXECUTABLE) > -set(${result_variable} "" PARENT_SCOPE) > -message(WARNING "Should specify a qmake Qt5 binary. Can't check > ${qt_variable}") > -

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a reviewer: apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. See also https://phabricator.kde.org/D6773 for making the resulting behaviour documented. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter Cc: #build_system

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set, qmake can be considered a required dependency, otherwise the