D7038: [server] Respect input region of sub-surfaces on pointer surface focus

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:24bdc06747ed: [server] Respect input region of sub-surfaces on pointer surface focus (authored by romangg).

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 44149. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=42733=44149 BRANCH inputRegionSubSurfaces REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg edited the summary of this revision. romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a dependent revision: D15900: Add unit test for subsurface input mask detection. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson added a comment. I think maybe it should, but it should be changed with surfaceAt REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added a comment. > QRectF(QPoint(0, 0), size()).contains(position) Shouldn't it be QRect instead? (again) If it should be QRectF indeed, could someone please explain why? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 42733. romangg added a comment. - Update version number - Do code duplication instead of pointers - Add comment about code duplication REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=42725=42733 BRANCH

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 42725. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=18059=42725 BRANCH inputRegionSubSurfaces REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I've written you a unit test. I can either take over this or upload as a separate review that you can merge in. INLINE COMMENTS > zzag wrote in

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#134955 , @graesslin wrote: > I like that refactoring  - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt? Maybe `findSurfaceHelper`. REPOSITORY

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:819 > position is a float So, it would be fine to return `true` in the following case: QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10)); ? REPOSITORY R127 KWayland REVISION DETAIL

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in surface_interface.cpp:819 > Shouldn't it be QRect instead? position is a float REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: davidedmundson, zzag,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > surface_interface.cpp:819 > + > +return !size.isEmpty() && QRectF(QPoint(0, 0), size).contains(position); > +} Shouldn't it be QRect instead? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#265444 , @graesslin wrote: > any update on this? Currently I'm working on other stuff and don't want to increase the mental load. I really only need this when looking again into sub-surfaces to handle

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

graesslin added a comment. Restricted Application added a subscriber: kde-frameworks-devel. any update on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

graesslin added a comment. I like that refactoring  - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: subdiff, #frameworks, graesslin Cc:

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

subdiff marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: subdiff, #frameworks, graesslin Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

subdiff updated this revision to Diff 18059. subdiff added a comment. Use function pointers. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=17500=18059 REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED FILES

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please verify that this does not break Qt! (Qt has a very special handling of subsurfaces and we have lots of workarounds for Qt there) Also please add a unit test

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

subdiff created this revision. subdiff added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY I noticed that while working on my GSoC Xwayland project and using sub-surfaces with empty