This revision was automatically updated to reflect the committed changes.
sitter marked an inline comment as done.
Closed by commit R290:ef15ef0889d2: kpackagetool can now write appstream data
to a file (authored by sitter).
CHANGED PRIOR TO COMMIT
sitter marked an inline comment as done.
sitter added inline comments.
INLINE COMMENTS
> apol wrote in kpackagetool.cpp:473
> Why the `? true : false`?
lol, brain fart that.
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7069
To: sitter, apol,
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
INLINE COMMENTS
> kpackagetool.cpp:473
> +// Standard value is unprocessed string we'll need to deal
> with.
> +object.value("NoDisplay").toString() ==
>
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Previously kpackagetool used STDOUT as output for the appstream xml data
it generated. This has various problems:
- cannot print