D7249: Return high-resolution line edit clear icon

2017-08-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R252:588cd0075612: Return high-resolution line edit clear icon (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7249?vs=18000=18757#toc REPOSITORY R252 Framework Integration

D7249: Return high-resolution line edit clear icon

2017-08-15 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kstyle.cpp:419 > just QIcon::fromTheme(directionalThemeName, "edit-clear") You mean `QIcon::fromTheme(directionalThemeName, QIcon::fromTheme("edit-clear"));`? REPOSITORY R252 Framework Integration REVISION DETAIL

D7249: Return high-resolution line edit clear icon

2017-08-15 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kstyle.cpp:419 > + > +QIcon icon = QIcon::fromTheme(directionalThemeName); > + just QIcon::fromTheme(directionalThemeName, "edit-clear")

D7249: Return high-resolution line edit clear icon

2017-08-15 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. +1 from me. Sounds sensible. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D7249 To: broulik, kde-frameworks-devel, hpereiradacosta Cc: hpereiradacosta, #frameworks

D7249: Return high-resolution line edit clear icon

2017-08-11 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Qt just returns a 16px pixmap by default leading to blurry results when larger icon sizes for small icons are configured by the user. TEST