This revision was automatically updated to reflect the committed changes.
Closed by commit R241:774b303c9680: [DropJob] Enable drag and drop in a
read-only folder (authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7272?vs=24601=25229
REVISION
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7272
To: chinmoyr, #frameworks, dfaure
Cc: mreeves, ngraham
chinmoyr added a comment.
ping
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7272
To: chinmoyr, #frameworks, dfaure
Cc: mreeves, ngraham
chinmoyr updated this revision to Diff 24601.
chinmoyr added a comment.
Restricted Application added a project: Frameworks.
1.Replaced PrivilegeExecution flag
2.Made variable m_flags const again
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ngraham added a comment.
How are we doing here?
REVISION DETAIL
https://phabricator.kde.org/D7272
To: chinmoyr, #frameworks, dfaure
Cc: ngraham
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good otherwise.
(Maybe extend the unittest for dropjob to test the polkit case too?)
INLINE COMMENTS
> dropjob.cpp:107
> +if (m_flags &
chinmoyr added a task: T6561: Polkit support in KIO.
REVISION DETAIL
https://phabricator.kde.org/D7272
To: chinmoyr, #frameworks, dfaure
chinmoyr created this revision.
REVISION SUMMARY
This patch adds PrivilegeExecution and other relevant code to KIO::DropJob.
With this DnD can be done in a read-only folder.
BRANCH
dropjob
REVISION DETAIL
https://phabricator.kde.org/D7272
AFFECTED FILES
src/widgets/dropjob.cpp
To:
