This revision was automatically updated to reflect the committed changes.
Closed by commit R265:9a7be02eabe8: Deprecate KStandardAction::Help (authored
by elvisangelaccio).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7292?vs=18154&id=18350#toc
REPOSITORY
R265 KConfigWidgets
CHANGES
dhaumann added a comment.
David's ship-it is good enough, please commit :)
REPOSITORY
R265 KConfigWidgets
BRANCH
deprecate-help
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks, dfaure
Cc: dhaumann
elvisangelaccio added a comment.
@dhaumann Ping, are you still not convinced by this change?
REPOSITORY
R265 KConfigWidgets
BRANCH
deprecate-help
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks, dfaure
Cc: dhaumann
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R265 KConfigWidgets
BRANCH
deprecate-help
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks, dfaure
Cc: dhaumann
elvisangelaccio updated this revision to Diff 18154.
elvisangelaccio added a comment.
- @deprecated since...
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7292?vs=18093&id=18154
BRANCH
deprecate-help
REVISION DETAIL
https://phabricator.kde.org
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7292#135318, @dhaumann wrote:
> Not sure, but is that reason enough to deprecate API? This doesn't sound
convincing yet...
Well, I can think of other reasons:
- you wouldn't add a new enum value unless there is
dhaumann added a comment.
Not sure, but is that reason enough to deprecate API? This doesn't sound
convincing yet...
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks
Cc: dhaumann
elvisangelaccio added a dependency: D7287: Improve KStandardAction apidox..
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
According to lxr, no one is using it (applications use HelpContents
to show the handbooks). So just mark it as deprecated for removal.
REPOSITORY
R265 KConfigWidgets
BRANCH
depreca