D7293: Deprecate KStandardAction::SaveOptions

2017-08-18 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R265:157663e2f8f4: Deprecate KStandardAction::SaveOptions (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7293?vs=18155&id=18349#toc REPOSITORY R265 KConfigWidgets

D7293: Deprecate KStandardAction::SaveOptions

2017-08-15 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Indeed I have never seen "Save Settings" anywhere, and git log says it was added in 2000, with a bunch of other standard actions, looks like "just in case" to me. REPOSITORY R265 KConfig

D7293: Deprecate KStandardAction::SaveOptions

2017-08-14 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 18155. elvisangelaccio added a comment. - @deprecated since... REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7293?vs=18094&id=18155 BRANCH deprecate-saveoptions REVISION DETAIL https://phabricator.

D7293: Deprecate KStandardAction::SaveOptions

2017-08-13 Thread Elvis Angelaccio
elvisangelaccio added a dependency: D7287: Improve KStandardAction apidox.. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7293 To: elvisangelaccio, #frameworks

D7293: Deprecate KStandardAction::SaveOptions

2017-08-13 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY According to lxr, no one is using it. So just mark it as deprecated for removal. REPOSITORY R265 KConfigWidgets BRANCH deprecate-saveoptions REVISION DETAIL https://phabricator.