aacid closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7461
To: nibags, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
nibags added a comment.
It seems that I do not have access to commits. You better push it
REPOSITORY
R216 Syntax Highlighting
BRANCH
add-apparmor-syntax (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D7461
To: nibags, #kate, #framework_syntax_highlighting,
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Thanks, I am fine with this now. Shall I push this for you, or do you have
commit access as well?
REPOSITORY
R216 Syntax Highlighting
BRANCH
add-apparmor-syntax (branched from
nibags added a comment.
Ready! I've updated the license. If you need me to change something else (or
if there is something you don't like), let me know.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7461
To: nibags, #kate,
nibags updated this revision to Diff 19578.
nibags added a comment.
- License is changed to MIT
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7461?vs=18983=19578
BRANCH
add-apparmor-syntax (branched from master)
REVISION DETAIL
dhaumann added a comment.
From what I can tell, the xml file looks quite good, although it contains
many rules so it is hard to completely review this.
With respect to MIT: We were discussing licensing last Akademy conference
(this year), and the issue with LGPL is that we are not even
nibags updated this revision to Diff 18983.
nibags added a comment.
- Updated AppArmor syntax highlighting file:
1. Updating https://phabricator.kde.org/D7461: Add syntax highlighting for
AppArmor Profiles. #
Updated AppArmor syntax highlighting file.
Hi! Sorry for the delay
nibags added a comment.
OK, I'll correct it.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7461
To: nibags, #kate, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, cullmann, #framework_syntax_hightlighting, #frameworks, vkrause
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
See Christoph's comments. And indeed, please remove all hard-coded colors.
Also, please provide a test file that is preferrably licensed under MIT.
INLINE COMMENTS
>
cullmann added a comment.
Three things I see ATM:
1. Please no hard coded colors, are they really necessary?
2. I think we want some test file for it with reference in the autotests
directory
3. If possible please MIT license
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
nibags added a reviewer: Framework: Syntax Hightlighting.
nibags added a project: Framework: Syntax Hightlighting.
nibags added a subscriber: Framework: Syntax Hightlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7461
To: nibags, #kate,
nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
AppArmor is a Linux security module that provides mandatory access control on
Linux.
The AppArmor Profiles are plain text files that
12 matches
Mail list logo
