D7660: Fix a regression caused by changing backspace key behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0f2335f3edc0: Fix compilation (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=24349=24361 REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

bcooksley added a comment. Can the compile fix please be committed? Otherwise we need to revert the entire patch to ensure Frameworks remains buildable. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein,

D7660: Fix a regression caused by changing backspace key behavior

brauch reopened this revision. brauch added inline comments. INLINE COMMENTS > katedocument_test.cpp:452 > auto view = > static_cast(doc.createView(nullptr)); > +view.config()->setBackspaceRemoveComposed(true); >

D7660: Fix a regression caused by changing backspace key behavior

brauch added a comment. After this was submitted master doesn't compile for me, and if I fix the compile in the trivial way the test fails. Can you have another look? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich,

D7660: Fix a regression caused by changing backspace key behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c9b412d40334: Fix a regression caused by changing backspace key behavior (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. I can commit but it is showing as not accepted. So I'll just wait for the final confirmation. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff, cullmann Cc:

D7660: Fix a regression caused by changing backspace key behavior

cullmann added a comment. If I don't misread the current diff, all things got done. Can you commit or shall I do so for you? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff Cc: mwolff,

D7660: Fix a regression caused by changing backspace key behavior

cullmann accepted this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff, cullmann Cc: mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks

D7660: Fix a regression caused by changing backspace key behavior

mwolff resigned from this revision. mwolff added a comment. ping? can this go in? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff Cc: mwolff, ngraham, anthonyfieroni, cullmann, jgrulich,

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij updated this revision to Diff 21916. safaalfulaij added a comment. - Applying last comment (hopefully I did what you meant :!) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19781=21916 BRANCH master REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. In https://phabricator.kde.org/D7660#158479, @ngraham wrote: > @safaalfulaij, any progress on the latest comments? Not really. I was busy with college. I'll try finishing it in the coming week. REPOSITORY R39 KTextEditor REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

ngraham added a comment. @safaalfulaij, any progress on the latest comments? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann Cc: ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein,

D7660: Fix a regression caused by changing backspace key behavior

anthonyfieroni added inline comments. INLINE COMMENTS > katedocument.cpp:3169-3223 > if (!(config()->backspaceIndents())) { > // ordinary backspace > -KTextEditor::Cursor beginCursor(line, > view->textLayout(c)->previousCursorPosition(c.column())); > +

D7660: Fix a regression caused by changing backspace key behavior

cullmann added a comment. All issues addressed, or? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann Cc: cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij updated this revision to Diff 19781. safaalfulaij added a comment. - Typos and better if statement structure REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19370=19781 BRANCH master REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. I think one further revision would be helpful, then the patch should be good to go in. INLINE COMMENTS > navigationconfigwidget.ui:138 > + > + When selected,

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. In https://phabricator.kde.org/D7660#144736, @jgrulich wrote: > The bug report is not publicly available, but it was about kate not removing composed characters, while other software do that. I now checked this with LibreOffice and QtCreator and it seems to

D7660: Fix a regression caused by changing backspace key behavior

jgrulich added a comment. In https://phabricator.kde.org/D7660#144734, @safaalfulaij wrote: > In https://phabricator.kde.org/D7660#144706, @jgrulich wrote: > > > Not sure I can say much, I wrote this patch because I got a bug report where for Indic locales they were not able to

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. In https://phabricator.kde.org/D7660#144706, @jgrulich wrote: > Not sure I can say much, I wrote this patch because I got a bug report where for Indic locales they were not able to remove composed characters. while other software (QtCreator, Libreoffice)

D7660: Fix a regression caused by changing backspace key behavior

jgrulich added a comment. In https://phabricator.kde.org/D7660#144542, @dhaumann wrote: > @jgrulich Can you comment on this, since the old patch that this change refers came from you ? :-) I'm sure you understand this better than me. Not sure I can say much, I wrote this patch

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij updated this revision to Diff 19370. safaalfulaij added a comment. - Fix global and local view values REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19368=19370 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7660

D7660: Fix a regression caused by changing backspace key behavior

dhaumann added a comment. The concept with the 'Set' flag is not yet correct. INLINE COMMENTS > kateconfig.cpp:1241 > m_autoBracketsSet(false), > +m_backspaceRemoveComposed(false), > m_view(nullptr) Should be: m_backspaceRemoveComposed_Set_(False) > kateconfig.cpp:1288 >

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij updated this revision to Diff 19368. safaalfulaij added a comment. - Add the implementation of backspaceRemoveComposed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19097=19368 BRANCH master REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

dhaumann added reviewers: jgrulich, hein. dhaumann added a subscriber: jgrulich. dhaumann added a comment. @jgrulich Can you comment on this, since the old patch that this change refers came from you ? :-) I'm sure you understand this better than me. REPOSITORY R39 KTextEditor REVISION

D7660: Fix a regression caused by changing backspace key behavior

dhaumann added subscribers: hein, dhaumann. dhaumann added a comment. @hein Are you familiar with this sort of behaviour? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor Cc: dhaumann, hein, kwrite-devel, #frameworks

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor Cc: kwrite-devel, #frameworks

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This is a patch trying to fix the regression caused by an old patch .