D7884: - Increase size of trailing mark

2017-10-17 Thread Helio Castro
This revision was automatically updated to reflect the committed changes. Closed by commit R39:92ec63dd1b07: - Increase size of trailing mark (authored by helio). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=20330=20903 REVISION DETAIL

D7884: - Increase size of trailing mark

2017-10-17 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Then I would say => merge it. And thanks for the work! REPOSITORY R39 KTextEditor BRANCH big_trailing REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff,

D7884: - Increase size of trailing mark

2017-10-17 Thread Helio Castro
helio added a comment. In https://phabricator.kde.org/D7884#154232, @sars wrote: > I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark. I did not changed the current behavior,

D7884: - Increase size of trailing mark

2017-10-11 Thread Kåre Särs
sars added a comment. I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc:

D7884: - Increase size of trailing mark

2017-10-11 Thread Christoph Cullmann
cullmann added a comment. Given it seems Atom even has the option to choose the sign for that, we can live with an option I assume (and the code for it is already written anyways). Others ok with that, too? REPOSITORY R39 KTextEditor REVISION DETAIL

D7884: - Increase size of trailing mark

2017-10-10 Thread Helio Castro
helio added a comment. Ping ? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-10-04 Thread Helio Castro
helio updated this revision to Diff 20330. helio added a comment. Rebase on current master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19888=20330 BRANCH big_trailing REVISION DETAIL https://phabricator.kde.org/D7884 AFFECTED FILES

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro
helio added a comment. In https://phabricator.kde.org/D7884#148489, @cullmann wrote: > I would rather go with the "make the markers much larger but less contrast" solution than a setting for their size. > Perhaps we really just need to look at how other editors do that. >

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro
helio added a comment. Fixed requests REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro
helio updated this revision to Diff 19888. helio marked 3 inline comments as done. helio added a comment. - Moved calc logic to updateMarkerSize - Fix identation - Make value properly float - Update view when apply pressed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7884: - Increase size of trailing mark

2017-09-24 Thread Christoph Cullmann
cullmann added a comment. I would rather go with the "make the markers much larger but less contrast" solution than a setting for their size. Perhaps we really just need to look at how other editors do that. Eye-cancer like markers are no solution either, but I agree that if people turn

D7884: - Increase size of trailing mark

2017-09-24 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:272 > + > +pen.setWidthF(spaceWidth() / (3.5 - (m_markerSize * 0.5))); > pen.setCapStyle(Qt::RoundCap); You can move width calculation in setmarkersize to safe unwanted calculations. > katerenderer.h:406 >

D7884: - Increase size of trailing mark

2017-09-24 Thread Helio Castro
helio added a comment. Is not that simple. Change only the color is fine, but then the effect is almost imperceptible, Right now from home i'm using a 25' 2560x1440 resolution with fonts in size 10. Is a regular monitor, not the most expensive. Even changing the color a single pixel is

D7884: - Increase size of trailing mark

2017-09-22 Thread Dominik Haumann
dhaumann added a comment. Kate already has many options, so we try to be careful with adding even more options. What I would like to clarify first is the use case: If I understand correctly, the trailing space visualization is too decent for you. The decency is indeed intended, since

D7884: - Increase size of trailing mark

2017-09-22 Thread Helio Castro
helio added a comment. F3921383: configsize.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: sars, #frameworks, cullmann, dhaumann

D7884: - Increase size of trailing mark

2017-09-22 Thread Helio Castro
helio updated this revision to Diff 19786. helio added a comment. - Make size configurable keeping the original default REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19686=19786 BRANCH big_trailing REVISION DETAIL

D7884: - Increase size of trailing mark

2017-09-20 Thread Kevin Funk
kfunk added a comment. In https://phabricator.kde.org/D7884#147087, @sars wrote: > I think "spaceWidth() / 2" goes a little bit too far. I agree. The 'before' screenshot looks better in my eyes. The trailing mark indicator is supposed to be a *subtle* hint, not something causing

D7884: - Increase size of trailing mark

2017-09-20 Thread Kåre Särs
sars added a comment. I think "spaceWidth() / 2" goes a little bit too far. Shouldn't spaceWidth() fix the HiDPI problem? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: sars, #frameworks, cullmann, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio added a comment. Result of change using kdevelop F3918646: screenshot.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio updated this revision to Diff 19686. helio added a comment. - Using same code guideline as previous entry REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19685=19686 BRANCH big_trailing REVISION DETAIL

D7884: - Increase size of trailing mark

2017-09-20 Thread Kevin Funk
kfunk added a comment. Screenshots please, for changes like this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio added reviewers: mwolff, kfunk. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On HiDPI screens and/or usage of small fonts current size of marker is so small making it almost invisible, even with a saturated color