davidedmundson abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
davidedmundson added a comment.
@mart Kai did it already.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
mart added inline comments.
INLINE COMMENTS
> iconitem.cpp:624
> +
> +if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) {
> +animated = false;
enclose this part with #ifdef on Qt version?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
bcooksley requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot,
bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Reopening - This breaks the build with Qt 5.7 based systems, which is the
minimum requirement for Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:94235482f9ab: Dont animate IconItem in software
mode (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks,
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
IconItem uses a gorgeous shader to fade between two states. This doesn't