D8021: Don't switch Location Bar mode with Escape key

ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: kde-frameworks-devel, rkflx, #frameworks, michaelh, ngraham, bruns

D8021: Don't switch Location Bar mode with Escape key

ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Abandoning in favor of D16980 , which I think makes more sense. In retrospect, you guys were right and this was a stupid idea: the escape key should definitely continue to work like

D8021: Don't switch Location Bar mode with Escape key

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: rkflx, #frameworks

D8021: Don't switch Location Bar mode with Escape key

broulik added a comment. > If it were done that way, I could agree to the patch. Agreed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: rkflx, #frameworks

D8021: Don't switch Location Bar mode with Escape key

rkflx added a comment. In https://phabricator.kde.org/D8021#149796, @broulik wrote: > I don't fully understand the bug report. The key point from the bug report is probably this: > If the config option 'editable location bar' is used This patch disables `Esc`

D8021: Don't switch Location Bar mode with Escape key

rkflx added a comment. -1 from me. It's a feature, not a bug. `Esc` is the standard way to return to previous GUI states, you use this subconsciously without needing to actively think about some other way (at least I do). In addition, Windows Explorer also does it the same way. >

D8021: Don't switch Location Bar mode with Escape key

broulik added a comment. The question is: why? I find Escape a natural way to exit editing and never used Ctrl+L. I don't fully understand the bug report. If Ctrl+L should only switch to edit mode, how would you exit again if you remove Escape handling? INLINE COMMENTS >

D8021: Don't switch Location Bar mode with Escape key

ngraham added reviewers: Frameworks, elvisangelaccio, broulik, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: #frameworks

D8021: Don't switch Location Bar mode with Escape key

ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 383984 Don't switch from editable to breadcrumb mode when htting the Escape key. Clients already implement their own ways to