z3ntu edited the summary of this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8076
To: z3ntu, #frameworks, dfaure, davidedmundson
Cc: ltoscano, ngraham
ltoscano added a comment.
As mentioned on IRC, this is a starting point but maybe the logic should be
changed so that there is no error on connection is at least a mount point is
accessible; the error should be on access.
PS: changes to the commit message in the git patch are not reflect
z3ntu updated this revision to Diff 20163.
z3ntu added a comment.
Add the bug keyword
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8076?vs=20160&id=20163
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8076
AFFECTED FILES
nfs/nfsv3.
z3ntu added a comment.
Well as we don't add failed mounts to the `failList` (if they fail because of
13 / MNT3ERR_ACCES) so the line `if (failList.size() == exportsCount) {` won't
work then.
Will add the bug keyword. Didn't know BugZilla and Phabricator were connected
:)
REPOSITORY
R
ngraham added reviewers: Frameworks, dfaure, davidedmundson.
ngraham added a comment.
Thanks for the patch! Instead of a bugzilla link, you can just use a special
keyword: "BUG: 375249"
This will ensure that the bug gets closed once the patch is accepted and
merged.
REPOSITORY
R320 KI
