This revision was automatically updated to reflect the committed changes.
Closed by commit R39:06ab983c7a3d: Minor spell check interface fixes (authored
by croick).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8154?vs=20381&id=20407
REVISION DETAIL
htt
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Lgtm.
REPOSITORY
R39 KTextEditor
BRANCH
spellfixes
REVISION DETAIL
https://phabricator.kde.org/D8154
To: croick, #ktexteditor, dhaumann
Cc: dhaumann, #frameworks, cullmann, sars
croick added a comment.
In https://phabricator.kde.org/D8154#152602, @dhaumann wrote:
> Looks already quite good. Btw, are there any bug reports in the Kate or
frameworks-ktexteditor product on bugs.kde.org that you fix here?
I didn't find one. I just discovered these yesterday an
dhaumann added a comment.
Looks already quite good. Btw, are there any bug reports in the Kate or
frameworks-ktexteditor product on bugs.kde.org that you fix here?
INLINE COMMENTS
> spellcheckdialog.cpp:198
>
> -
> m_currentSpellCheckRange.setRange(KTextEditor::Range(replacementStartCu
croick added inline comments.
INLINE COMMENTS
> spellcheckbar.cpp:146
> d->deleteProgressDialog(false); // this method can be called in response
> to
> +d->replaceAllMap.clear();
> // pressing 'Cancel' on the dialog
This might have been a feature, but without clearing the map, the
croick created this revision.
croick added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- empty document does not resize bar widget when spell check is started
without effect
- replaci
