davidedmundson abandoned this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8346
To: davidedmundson
Cc: xuetianweng, #frameworks
davidedmundson added a comment.
I've realised there's much more to do:
The existing code has some super weird behaviour.
Find there's an SNI watcher, but no host (i.e kded but no plasmashell) -
that's fine, we don't check and create one anyway
But if a host gets added/removed -
xuetianweng added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:882
> +
> +QDBusPendingReply pendingReply =
> statusNotifierWatcher->connection().call(call);
> +auto watcher = new QDBusPendingCallWatcher(pendingReply);
The template is not necessary here. Maybe auto
davidedmundson planned changes to this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8346
To: davidedmundson
Cc: xuetianweng, #frameworks
xuetianweng added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:879
> +} else {
> +QDBusMessage call =
> QDBusMessage::createMethodCall(statusNotifierWatcher->service(),
> statusNotifierWatcher->path(),
> QStringLiteral("org.freedesktop.DBus.Properties."),
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 385867
TEST PLAN
Ran test
killed plasmashell
SNI restored when plasmashell came back
REPOSITORY
R289 KNotifications
