renatoo updated this revision to Diff 21693.
renatoo added a comment.
Renamed section from 'sared' to 'remote'
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21649=21693
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
mwolff added a comment.
But thinking 5s more about it, I personally would say that using "Remote" for
the category would be OK for now.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, mwolff,
mwolff added a comment.
Well, but if we use `Network` for `remote://` already, then the group should
also have this label, no? I don't see an issue with this, really. On the
contrary - maybe we could in the future remove the `remote://` link and let the
category header react to a click,
renatoo added a comment.
In https://phabricator.kde.org/D8434#162727, @mwolff wrote:
> lgtm overall. but I wonder about the naming choice. "Shared" is confusing,
to me personally at least. Why not call it "Remote" or "Network"? The reasoning
is that "shared" for me is only LAN/WLAN
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8434#162727, @mwolff wrote:
> lgtm overall. but I wonder about the naming choice. "Shared" is confusing,
to me personally at least. Why not call it "Remote" or "Network"? The reasoning
is that "shared" for me is only
mwolff added a comment.
lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to
me personally at least. Why not call it "Remote" or "Network"? The reasoning is
that "shared" for me is only LAN/WLAN shared stuff, while "remote://" allows
arbitrary remote links. I use it
renatoo updated this revision to Diff 21649.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21623=21649
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 21623.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21585=21623
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
ngraham added a comment.
+1 for the idea! Needs more screenshots. :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks
renatoo updated this revision to Diff 21585.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21297=21585
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 21297.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21238=21297
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
mlaurent added a comment.
+1 for me :) But I am not the maintainer :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks
renatoo updated this revision to Diff 21238.
renatoo added a comment.
Used QLatin1String for static strings
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21229=21238
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:168
> +if (protocol == QLatin1String("remote") ||
> +KProtocolInfo::protocolClass(protocol) != ":local") {
> +return NetworkType;
!= QLatin1String(":local")
REPOSITORY
R241 KIO
REVISION
renatoo updated this revision to Diff 21229.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21176=21229
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo added reviewers: ngraham, Frameworks, Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: #frameworks
renatoo edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Group all network related urls into the 'shared' section, to make it
clear to the user what is access through network or not
REPOSITORY
19 matches
Mail list logo