D8434: Created 'shared' section

2017-11-01 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21693. renatoo added a comment. Renamed section from 'sared' to 'remote' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21649=21693 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-11-01 Thread Milian Wolff
mwolff added a comment. But thinking 5s more about it, I personally would say that using "Remote" for the category would be OK for now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: elvisangelaccio, mwolff,

D8434: Created 'shared' section

2017-11-01 Thread Milian Wolff
mwolff added a comment. Well, but if we use `Network` for `remote://` already, then the group should also have this label, no? I don't see an issue with this, really. On the contrary - maybe we could in the future remove the `remote://` link and let the category header react to a click,

D8434: Created 'shared' section

2017-11-01 Thread Renato Oliveira Filho
renatoo added a comment. In https://phabricator.kde.org/D8434#162727, @mwolff wrote: > lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only LAN/WLAN

D8434: Created 'shared' section

2017-11-01 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D8434#162727, @mwolff wrote: > lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only

D8434: Created 'shared' section

2017-11-01 Thread Milian Wolff
mwolff added a comment. lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to me personally at least. Why not call it "Remote" or "Network"? The reasoning is that "shared" for me is only LAN/WLAN shared stuff, while "remote://" allows arbitrary remote links. I use it

D8434: Created 'shared' section

2017-10-31 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21649. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21623=21649 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-10-31 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21623. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21585=21623 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-10-30 Thread Nathaniel Graham
ngraham added a comment. +1 for the idea! Needs more screenshots. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks

D8434: Created 'shared' section

2017-10-30 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21585. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21297=21585 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-10-25 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21297. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21238=21297 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-10-24 Thread Laurent Montel
mlaurent added a comment. +1 for me :) But I am not the maintainer :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks

D8434: Created 'shared' section

2017-10-24 Thread Renato Oliveira Filho
renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks

D8434: Created 'shared' section

2017-10-24 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21238. renatoo added a comment. Used QLatin1String for static strings REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21229=21238 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-10-24 Thread Laurent Montel
mlaurent added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:168 > +if (protocol == QLatin1String("remote") || > +KProtocolInfo::protocolClass(protocol) != ":local") { > +return NetworkType; != QLatin1String(":local") REPOSITORY R241 KIO REVISION

D8434: Created 'shared' section

2017-10-24 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21229. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21176=21229 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8434: Created 'shared' section

2017-10-23 Thread Renato Oliveira Filho
renatoo added reviewers: ngraham, Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: #frameworks

D8434: Created 'shared' section

2017-10-23 Thread Renato Oliveira Filho
renatoo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo Cc: #frameworks

D8434: Created 'shared' section

2017-10-23 Thread Renato Oliveira Filho
renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Group all network related urls into the 'shared' section, to make it clear to the user what is access through network or not REPOSITORY