This revision was automatically updated to reflect the committed changes.
Closed by commit R293:d636fdc569ea: Remove unused config.h.cmake entries
(authored by davidk).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8461?vs=22171=22172
REVISION DETAIL
davidk updated this revision to Diff 22171.
davidk added a comment.
Improve commit message
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8461?vs=21277=22171
BRANCH
cleanup
REVISION DETAIL
https://phabricator.kde.org/D8461
AFFECTED FILES
davidk added a comment.
Thanks for the git hint and the revew.
Then we should remove this code too.
REPOSITORY
R293 Baloo
BRANCH
cleanup
REVISION DETAIL
https://phabricator.kde.org/D8461
To: davidk, dfaure
Cc: dfaure, #frameworks
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
The answer to "I'm not sure why" is easy: `git log -S MALLOC` shows exactly
two commits, the one that introduced the usage of this stuff, and the one that
removed it again. Ain't git
davidk updated this revision to Diff 21277.
davidk added a comment.
Fix commit message.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8461?vs=21276=21277
BRANCH
cleanup
REVISION DETAIL
https://phabricator.kde.org/D8461
AFFECTED FILES
davidk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I'm not sure why they were introduced, but they aren't used anywhere in the
code.
TEST PLAN
- "grep -r HAVE_MALLOC_H baloo"
-
