This revision was automatically updated to reflect the committed changes.
Closed by commit R252:35656828f12c: Support downloading the 2nd or 3rd download
link from a KNS product (authored by Zren).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8636?vs=21841=22014#toc
REPOSITORY
R252
apol added a comment.
In https://phabricator.kde.org/D8636#164605, @Zren wrote:
> Quick note since I just notice you suggested a lowercase `i` in
`?linkid=3`, should I change it to lowercase or stick with camelcase?
I don't really mind, maybe leave it as `link`?
REPOSITORY
Zren added a comment.
Quick note since I just notice you suggested a lowercase `i` in `?linkid=3`,
should I change it to lowercase or stick with camelcase?
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren, apol
Cc: #frameworks
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren, apol
Cc: #frameworks
Zren added a comment.
Good idea. This will future proof us in case we ever want
`?linkName=tiledmenu-v18-kde5.9.plasmoid` or something as well.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren, apol
Cc: #frameworks
Zren updated this revision to Diff 21841.
Zren edited the summary of this revision.
Zren edited the test plan for this revision.
REPOSITORY
R252 Framework Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8636?vs=21823=21841
REVISION DETAIL
ngraham edited the summary of this revision.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren, apol
Cc: #frameworks
apol added a comment.
Hi,
Thanks for your patch! It's something I pondered doing at some point but then
got busy with other stuff.
I was thinking that instead of adding yet another part, maybe we could have
it as a URI query, this way we don't break the components that are parsing
Zren added a reviewer: apol.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren, apol
Cc: #frameworks
Zren edited the test plan for this revision.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren
Cc: #frameworks
Zren edited the test plan for this revision.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren
Cc: #frameworks
Zren created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Implementing the feature request in BUG #385429.
https://bugs.kde.org/show_bug.cgi?id=385429
LookAndFeels introduced the ability to set
12 matches
Mail list logo