This revision was automatically updated to reflect the committed changes.
Closed by commit R294:5dffdee21f20: do not show edit bookmarks action if
keditbookmarks is not installed (authored by sitter).
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R294 KBookmarks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8825
To: sitter, #frameworks, apol
Cc: apol
sitter updated this revision to Diff 22443.
sitter added a comment.
rebased
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8825?vs=22379=22443
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8825
AFFECTED FILES
sitter added inline comments.
INLINE COMMENTS
> apol wrote in kbookmarkmenu_p.h:42
> Why not in the cpp file?
It's used in 2 difference cpps.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D8825
To: sitter, #frameworks
Cc: apol
apol added a comment.
LGTM
INLINE COMMENTS
> kbookmarkmenu_p.h:42
>
> +#define KEDITBOOKMARKS_BINARY "keditbookmarks"
> +
Why not in the cpp file?
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D8825
To: sitter, #frameworks
Cc: apol
sitter created this revision.
sitter added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
keditbookmarks lives in applications, making it very likely that it is
not installed. this does already raise an error window explaining that
the binary is
