This revision was automatically updated to reflect the committed changes.
Closed by commit R309:03d24088ea68: Fix compile with QT_NO_CAST_FROM_ASCII
(authored by mlaurent).
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9044?vs=23114&id=23160
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R309 KService
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9044
To: mlaurent, dfaure
Cc: #frameworks
mlaurent updated this revision to Diff 23114.
mlaurent marked 4 inline comments as done.
mlaurent added a comment.
- Fix error found by David
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9044?vs=23113&id=23114
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
mlaurent added inline comments.
INLINE COMMENTS
> dfaure wrote in kbuildsycoca.cpp:248
> `fromLatin1` would do, it's ascii strings like "services" etc.
Yep I was not sure about this one.
It confirms that this one was incorrect.
I will fix all soon.
REPOSITORY
R309 KService
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kbuildservicegroupfactory.cpp:84
>
> -if (menuName != "/") {
> +if (menuName != QStringLiteral("/")) {
> // Make sure parent dir exists.
Us
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Compile it
REPOSITORY
R309 KService
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9044
AFFECTED F
mlaurent added a reviewer: dfaure.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D9044
To: mlaurent, dfaure
Cc: #frameworks
