This revision was automatically updated to reflect the committed changes.
Closed by commit R242:af00946f81c6: dont multiply svg sizes by
devicepixelratio (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9286?vs=23759=25823
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I'm 100% convinced Plasma needs to multiply it as it does everything in
device pixels.
However:
void FrameSvgItem::updateDevicePixelRatio()
davidedmundson added a comment.
I handle scaling everyewhere except for Plasma which does it's own thing.
I'm not convinced by this patch:
If this was Qt's devicePixelRatio this would definitely 100% make sense as
there we write all UI code in logical sizes.
But in
broulik added a comment.
Ping
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
broulik added a comment.
This fixes the gigantig scroll bars I had in plasmashell on X with 2x scaling.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
when the native high dpi scaling is enabled, some things gets scaled two
times,
as sizes
