jtamate abandoned this revision.
jtamate added a comment.
With the changes in https://phabricator.kde.org/D10376 this patch is not
needed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9862
To: jtamate, #frameworks, dfaure
Cc: michaelh
jtamate added a comment.
#10 0x7ff925c93845 in KJob::finishJob(bool) (this=0x221d0d0,
emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:101
#11 0x7ff925c93f9b in KJob::emitResult() (this=0x221d0d0) at
/g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
jtamate updated this revision to Diff 27444.
jtamate added a comment.
Now with an Q_ASSERT that really shows the origin of the problem.
In the case of pressing the "skip All" button when can't change permissions
is:
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
jtamate edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9862
To: jtamate, #frameworks, dfaure
Cc: michaelh
jtamate added a reviewer: dfaure.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9862
To: jtamate, #frameworks, dfaure
Cc: michaelh
jtamate updated this revision to Diff 27429.
jtamate added a comment.
I still can trigger the crash without the patch with KF5 5.42 (opensuse)
Improved the patch it a little bit, including a QASSERT to know where the
double finish originates.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE
jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
Copying several files to a file system where the rights can't be
changed, two dialogs asking for "Retry Skip
